* Correct link to Galaxy docs

* add trailing slash

* fix nxos_vxlan_vtep_vni issue (#42183)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 981c9f6a)

* Update eos_l2_interface.py (#42270)

(cherry picked from commit 51092c6e)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Revert "Account for empty string regexp in lineinfile (#41451)"

This reverts commit 4b5b4a76.

* Use context managers for interacting with files

* Store line and regexp parameters in a variable

* Add warning when regexp is an empty string

* Remove '=' from error messages

* Update warning message and add changelog

* Add tests

* Improve warning message

Offer an equivalent regexp that won't trigger the warning.
Update tests to match new warning.

* Add porting guide entry for lineinfile change

(cherry picked from commit fb55038d)

This import was removed by mistake. This is required for backward
compatibility.

Fixes: #41988

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* influxdb_query: fix use of common return results (#39626)


(cherry picked from commit aa874c3c)

* changelog: influxdb_query fix use of common return

* nsupdate.py: Fix typo (#42209)

Signed-off-by: David Galloway <dgallowa@redhat.com>
(cherry picked from commit 95392840)

* nsupdate_fix_hmac-sha384

PR #42101
(cherry picked from commit fc25d280)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

* [stable-2.5] ignore ansible.cfg in world writable cwd (#42070)

* ignore ansible.cfg in world writable cwd
 * also added 'warnings' to config
 * updated man page template
(cherry picked from commit b6f2aad6)

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>

* Update wrcwd_ansible.cfg.yml

* avoid loading vars on unspecified basedir (cwd)
(cherry picked from commit de0e11c0)

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>

Fixes #40626

* Due to issue in ncclient commit() method for Juniper
  device (ncclient/ncclient#238)
  add a workaround in junos netconf plugin to generate proper
  commit-configuration xml and execute it using ncclient
  generic `rpc()` method.

* Update junos_config doc

* Update changelog

(cherry picked from commit 88b966e2)

* service_facts correct meaning of state for systemd service units

Fixes #40809

Previously this module used the commend `systemctl list-unit-files
--type=service` to query state of services but list-unit-files only
shows enabled vs disabled which is not what we want for "state"

Signed-off-by: Adam Miller <admiller@redhat.com>

* make sure to define service_name before referencing it

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit bf1cc2f1)

(cherry picked from commit 77526a50)

(cherry picked from commit 11ce9542)

(cherry picked from commit abfcc35e)

This commit: fa5c0282 relied upon
features present in Jinja-2.10 and above.  The changes here allow us to
build the *rst* with older versions of jinja2.
(cherry picked from commit ad2e8dd6)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>

* Skip if insertbefore BOF until later (#41767)

If a line match is found in the file and no regexp is specified, insertbefore would improperly try to add a line if set to BOF.

Add tests for this scenario.

(cherry picked from commit eaae1318)

* Add changelog fragment

* Use inventory.get_host instead of direct access to inventory.hosts (#41860)

* Use inventory.get_host instead of direct access to inventory.hosts. Fixes #32152

* Prevent potential side effect, by using self._inventory.localhost directly instead of get_host

(cherry picked from commit 1a2ef092)

* Add changelog for #41860

* Stop displaying kinit pass input on a failure

* Fixed up minor logic info and added tests

(cherry picked from commit 9b7b564d)

(cherry picked from commit a8d4bf86)

(cherry picked from commit 0b2ec9b1)

(cherry picked from commit f1e41cbb)

also made it optimistic, rely on exceptions instead of copmlex if chains

(cherry picked from commit 11dbed13)

* fix minor issues with debug and item labels

 - no more `item=None`, we always have a label now
 - debug should only show expected information, either msg= or the var in var=
 - also fixed method name, deprecated misleading _get_item

(cherry picked from commit 27c43daa)

* Fix vyos_vlan aggregate issue & added tests (#41638)

* Fix vyos_vlan aggregate issue & Added tests

* Fix #2 for vyos_vlan aggregate issue

(cherry picked from commit 837c2165)

* Added changelog for vyos_vlan aggregate issue fix

* apt: fix apt-mark on debian6 (#41530)


(cherry picked from commit 2e68811c)

* Add changelog/fragment

steps taken from lib/ansible/executor/task_executor.py

fixes: https://github.com/ansible/ansible/issues/27520
(cherry picked from commit 23fbe0ce)

When parsing the distribution files such as /etc/os-release, we extract
the full distribution version but not the major version. As such, the
ansible_distribution_major_version ends up being 'NA' whereas the
ansible_distribution_version contains the full version.

Before this patch we get this on openSUSE Leap 15

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "NA"}, "changed": false}

After this patch we get this

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "15"}, "changed": false}

This also fixes the Tumbleweed distribution test to report a proper
major version and also adds a test for openSUSE Leap 15.0 to avoid
potential future regressions.

Fixes: #41410
(cherry picked from commit 1737b7be)

* fix nxos_linkagg issue (#41550)

* fix nxos_linkagg issue

* fix shippable

(cherry picked from commit 119e6d68)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

(cherry picked from commit 63f2ad87)

Co-authored-by: schp <schonhofen@gmail.com>

* Clarify append and groups behavior
* Document return values.
(cherry picked from commit 6fa2d9ac)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Fixes #34893 (#40166)

Fixes several bugs exposed in #34893
* Fixes relative path handling in copy so that it splits directories and
  reconstructs the correct file path
* Return failed in the proper circumstances

(cherry picked from commit ca4147f2)

* Add changelog for recursive copy fix

(cherry picked from commit cab0f215)

(cherry picked from commit d9945956)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>

(cherry picked from commit 58804041)

This reverts commit e9546337.

(cherry picked from commit 11bd3fd3)

Disabled due to lack of newer TLS version support on the test system.

(cherry picked from commit dce708e6)